Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

orphaned session records not cleaned (#329) #368

Merged
merged 17 commits into from
Jul 21, 2023
Merged

orphaned session records not cleaned (#329) #368

merged 17 commits into from
Jul 21, 2023

Conversation

markusraulf
Copy link
Contributor

Proposed change

  • Do not throw an error in RemoveSessionByUser() if orphaned session is found.
  • Add console commands to list and remove orphaned sessions.
  • Wrote test creating and removing orphaned session.

Type of change

  • '1 - 🐞 bug 🐞' - Bugfix (non-breaking change which fixes an issue)

Additional information

Checklist

  • [x ] The code change is tested and works locally.(❗)
  • [x ] There is no commented out code in this PR.(❕)
  • [x ] You improved or added new unit tests.(❕)
  • [x ] Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

markusraulf and others added 11 commits March 28, 2023 19:43
@NiklasSchmitt NiklasSchmitt added 4 - verified This issue or pull request was verified. 3 - wait for reviewer Znuny, it's your turn. labels Apr 14, 2023
@NiklasSchmitt
Copy link
Contributor

Hi @markusraulf,

thank you very much for your contribution to Znuny. I've checked your code and just updated some minor stuff here and there. I would approve and merge it after we reviewed & tested it internally.

Best,
Niklas

@dennykorsukewitz dennykorsukewitz added the 1 - 🐞 bug 🐞 An issue with the system. label Jun 9, 2023
@NiklasSchmitt NiklasSchmitt merged commit 2bc51e7 into znuny:dev Jul 21, 2023
5 of 6 checks passed
@NiklasSchmitt
Copy link
Contributor

This merge-request will be part of the upcoming Znuny version 7.0.9

@NiklasSchmitt NiklasSchmitt added this to the rel-7_0_9 milestone Jul 21, 2023
@dennykorsukewitz dennykorsukewitz removed the 3 - wait for reviewer Znuny, it's your turn. label Jul 21, 2023
@NiklasSchmitt NiklasSchmitt mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasSchmitt NiklasSchmitt NiklasSchmitt approved these changes

Assignees

@NiklasSchmitt NiklasSchmitt

Labels
1 - 🐞 bug 🐞 An issue with the system. 4 - verified This issue or pull request was verified.
Milestone
rel-7_0_9
Development

Successfully merging this pull request may close these issues.
3 participants
@markusraulf @NiklasSchmitt @dennykorsukewitz